<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104786/">http://git.reviewboard.kde.org/r/104786/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't have much experience with multiple currencies, but Thomas' comments made me think. I know when changing money at a bank, the two rates are not reciprocal, because the bank makes some money on each exchange. Is this also true for the exchange rates KMM retrieves on-line? If the rates are reciprocal, then the closest date is most accurate (can the date be later than the transaction instead of earlier?) However, if the rates are NOT reciprocal, than how preferable is a correct rate to a reciprocal rate on a closer date?
Jack
</pre>
<br />
<p>- Jack</p>
<br />
<p>On April 30th, 2012, 11:11 p.m., Alvaro Soliverez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Thomas Baumgart.</div>
<div>By Alvaro Soliverez.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 11:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There may be cases where only the reciprocal value for a given date is present, but if there is a price for a previous date, the latter will be used instead.
The fix here intends to use the most accurate value, which is the one in the exact date, even if it's the reciprocal one.
There might be performance issues. Perhaps a price cache should be considered in the future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran reports where this case is present, and unit tests.
There was no noticeable performance problem, but the set of prices was normal.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297437">297437</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(eef7126)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104786/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>