[Kmymoney-devel] Review Request: Extend filter in the tag view: Opened and Closed tags

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107827/#review23792
-----------------------------------------------------------

Ship it!



kmymoney/views/ktagsview.h
<http://git.reviewboard.kde.org/r/107827/#comment18188>

    There's no need to use assignments for all values except the first one. Enums have auto-increment. Probably use the following form to get some more documentation about the options:
    
    enum filterTypeE {
      eAllTags = 0,      ///< documentation ...
      eReferencedTags,   ///< doc of eRef...
      ..
      ..
      eClosedTags
    };


- Thomas Baumgart


On Dec. 20, 2012, 11:34 p.m., Alessandro Russo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107827/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 11:34 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Marko (mk-lists at email.de) asked me if I could extend the filter in the tag view. In the old implementation the filter had 3 option: All, Used tags, Unused Tags. With this patch I added two other option: Opened Tags and Closed Tags.
> 
> 
> Diffs
> -----
> 
>   kmymoney/views/ktagsview.h 50048b8 
>   kmymoney/views/ktagsview.cpp 7552500 
> 
> Diff: http://git.reviewboard.kde.org/r/107827/diff/
> 
> 
> Testing
> -------
> 
> Compile and run.
> 
> 
> Thanks,
> 
> Alessandro Russo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121221/72a57ebc/attachment.html>