<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107827/">http://git.reviewboard.kde.org/r/107827/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>







<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/107827/diff/1/?file=100504#file100504line79" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/views/ktagsview.h</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KTagsView : public QWidget, public Ui::KTagsViewDecl</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="k">enum</span> <span class="n">filterTypeE</span> <span class="p">{</span> <span class="n">eAllTags</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span> <span class="n">eReferencedTags</span> <span class="o">=</span> <span class="mi">1</span><span class="p">,</span> <span class="n">eUnusedTags</span> <span class="o">=</span> <span class="mi">2</span> <span class="p">};</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="k">enum</span> <span class="n">filterTypeE</span> <span class="p">{</span> <span class="n">eAllTags</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span> <span class="n">eReferencedTags</span> <span class="o">=</span> <span class="mi">1</span><span class="p">,</span> <span class="n">eUnusedTags</span> <span class="o">=</span> <span class="mi">2</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">eOpenedTags</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="mi"><span class="hl">3</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">eClosedTags</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="mi"><span class="hl">4</span></span> <span class="p">};</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's no need to use assignments for all values except the first one. Enums have auto-increment. Probably use the following form to get some more documentation about the options:

enum filterTypeE {
  eAllTags = 0,      ///< documentation ...
  eReferencedTags,   ///< doc of eRef...
  ..
  ..
  eClosedTags
};</pre>
</div>
<br />



<p>- Thomas</p>


<br />
<p>On December 20th, 2012, 11:34 p.m., Alessandro Russo wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KMymoney.</div>
<div>By Alessandro Russo.</div>


<p style="color: grey;"><i>Updated Dec. 20, 2012, 11:34 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marko (mk-lists@email.de) asked me if I could extend the filter in the tag view. In the old implementation the filter had 3 option: All, Used tags, Unused Tags. With this patch I added two other option: Opened Tags and Closed Tags.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile and run.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/views/ktagsview.h <span style="color: grey">(50048b8)</span></li>

 <li>kmymoney/views/ktagsview.cpp <span style="color: grey">(7552500)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107827/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>