[Kmymoney-devel] Review Request: BUG:213250 - Fix QIF Import creating unneeded brokerage accounts.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107797/#review23779
-----------------------------------------------------------


In case anyone might be about to have a look at this, please hold fire for a bit.

In this area of code, where the different investment types are actioned, there is already some duplication of code and my change was increasing that.  So, I'm in the process of extracting the commonality from the separate sections and moving that processing to be immediately before those sections.

So, hopefully, they will be much simpler and clearer.


- Allan Anderson


On Dec. 18, 2012, 12:39 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107797/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 12:39 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When importing a QIF file which contains investment accounts, a Brokerage account is created for each account, even if the transactions include a name for the investment account to be used. This is because the Brokerage account is created when the investment account line is encountered, and before the start of the transactions processing.  If several accounts are being imported, this creates a lot of clutter.
> The change delays the decision on Brokerage account creation until transaction processing occurs.
> 
> 
> This addresses bug 213250.
>     http://bugs.kde.org/show_bug.cgi?id=213250
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.cpp d535091 
> 
> Diff: http://git.reviewboard.kde.org/r/107797/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with a number of different QIF files.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121220/9763875d/attachment.html>