[Kmymoney-devel] Review Request: BUG:213250 - Fix QIF Import creating unneeded brokerage accounts.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107797/#review23694
-----------------------------------------------------------


If this, or something similar, is approved, there is something that needs to be considered about which I'm not in a position to make a judgement.

The way the patch works at the moment requires the investment 'L' record to contain only the '[]' for a brokerage account to be created.  The original code will create that account unconditionally; the transfer account is created, even in the absence of the square brackets that should enclose the account name.

As I don't have any genuine examples on which to base a decision, can anyone throw any light on this please?  I created an account in Quicken where the proceeds were retained in the investment account.  When exported, there was no 'L' record at all.  Is that good enough evidence?

- Allan Anderson


On Dec. 18, 2012, 12:39 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107797/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 12:39 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When importing a QIF file which contains investment accounts, a Brokerage account is created for each account, even if the transactions include a name for the investment account to be used. This is because the Brokerage account is created when the investment account line is encountered, and before the start of the transactions processing.  If several accounts are being imported, this creates a lot of clutter.
> The change delays the decision on Brokerage account creation until transaction processing occurs.
> 
> 
> This addresses bug 213250.
>     http://bugs.kde.org/show_bug.cgi?id=213250
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.cpp d535091 
> 
> Diff: http://git.reviewboard.kde.org/r/107797/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with a number of different QIF files.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121218/b9711243/attachment.html>