[Kmymoney-devel] Review Request: Prices: search reciprocal value before searching previous dates

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104786/
-----------------------------------------------------------

(Updated April 30, 2012, 11:11 p.m.)


Review request for KMymoney and Thomas Baumgart.


Changes
-------

Updated the patch with the check suggested by Thomas


Description
-------

There may be cases where only the reciprocal value for a given date is present, but if there is a price for a previous date, the latter will be used instead.
The fix here intends to use the most accurate value, which is the one in the exact date, even if it's the reciprocal one.

There might be performance issues. Perhaps a price cache should be considered in the future.


This addresses bug 297437.
    http://bugs.kde.org/show_bug.cgi?id=297437


Diffs (updated)
-----

  kmymoney/mymoney/mymoneyfile.cpp eef7126 

Diff: http://git.reviewboard.kde.org/r/104786/diff/


Testing
-------

Ran reports where this case is present, and unit tests.
There was no noticeable performance problem, but the set of prices was normal.


Thanks,

Alvaro Soliverez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120430/90606421/attachment-0001.html>