[Kmymoney-devel] Review Request: Prices: search reciprocal value before searching previous dates

[Alvaro Soliverez]

> On April 30, 2012, 8:10 p.m., Thomas Baumgart wrote:
> > I am thinking about the following use-case: you have a time line of three dates:
> > 
> > A -> B -> C
> > 
> > where C is the date you ask a price for, B is a reciprocal value and A is the price info for the currencies you ask for. In case 'exactDate' is false, B would contain the correct answer. AFAICS, your patch does not cover this case, right?
> > 
> > Other than that it's a start to solve the problem.

You are right, in case an exact date is not found, both should be searched, and the closest one returned. I'll correct the patch.


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104786/#review13158
-----------------------------------------------------------


On April 29, 2012, 7:05 p.m., Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104786/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 7:05 p.m.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Description
> -------
> 
> There may be cases where only the reciprocal value for a given date is present, but if there is a price for a previous date, the latter will be used instead.
> The fix here intends to use the most accurate value, which is the one in the exact date, even if it's the reciprocal one.
> 
> There might be performance issues. Perhaps a price cache should be considered in the future.
> 
> 
> This addresses bug 297437.
>     http://bugs.kde.org/show_bug.cgi?id=297437
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.cpp eef7126 
> 
> Diff: http://git.reviewboard.kde.org/r/104786/diff/
> 
> 
> Testing
> -------
> 
> Ran reports where this case is present, and unit tests.
> There was no noticeable performance problem, but the set of prices was normal.
> 
> 
> Thanks,
> 
> Alvaro Soliverez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120430/2db31945/attachment.html>