[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

> On Nov. 27, 2011, 1:54 a.m., Alvaro Soliverez wrote:
> > kmymoney/widgets/register.cpp, line 2023
> > <http://git.reviewboard.kde.org/r/103264/diff/1/?file=42243#file42243line2023>
> >
> >     Does this take into account cases where the account is not configured for online use?

As Thomas already foresaw, there is no problem here since "lastImportedTransactionDate" is being used. No matter whether the account is mapped or not, the existing online statement balance group marker will appear highlighted or normal depending on the file's balance.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8499
-----------------------------------------------------------


On Nov. 27, 2011, 1:16 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 1:16 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/register.h 8cd1a328fb690fad015a0de5943c984b7e7deca8 
>   kmymoney/widgets/register.cpp 39d991c30d531154fd2651a52ab2b6a199b92b32 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111127/21d4ca11/attachment.html>