[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8499
-----------------------------------------------------------



kmymoney/widgets/register.h
<http://git.reviewboard.kde.org/r/103264/#comment7211>

    The name is ambiguous.
    Perhaps something like isConsistentWithOnline might more descriptive



kmymoney/widgets/register.cpp
<http://git.reviewboard.kde.org/r/103264/#comment7212>

    This is a hint of a design problem.
    The calculation of the erroneous should be done at the MyMoneyAccount class, and not on the widget.
    The widget should only deal with the logic of how to display the inconsistency.
    The logic of what is wrong should be calculated deeper in the class hierarchy, at the "engine" level.
    Otherwise, when you change the way stuff is displayed, this logic is lost.



kmymoney/widgets/register.cpp
<http://git.reviewboard.kde.org/r/103264/#comment7213>

    Does this take into account cases where the account is not configured for online use?


- Alvaro Soliverez


On Nov. 27, 2011, 1:16 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 1:16 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/register.h 8cd1a328fb690fad015a0de5943c984b7e7deca8 
>   kmymoney/widgets/register.cpp 39d991c30d531154fd2651a52ab2b6a199b92b32 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111127/40d2f703/attachment.html>