[Kmymoney-devel] Reviewboard and Git

Allan agander_zz at aganderson.me.uk
Tue Nov 15 00:20:25 UTC 2011


On 14/11/11 22:16, Cristian Oneț wrote:
> On Monday 14 November 2011 22:11:32 you wrote:
>> Just finishing adding all the new files, etc.  Then, see where I'm up to
>> in this new world.  What am I to do with the new patches?  Is it a case
>> of resubmitting under git?
>
> You can commit them to a local branch in your repository and after testing
> that everything is OK (you've ported the patch correctly) submit the patch
> obtained by running 'git format-patch master --stdout>  csv.patch' to review.
>

All seems OK and the patches are ready.  I'm assuming that when KMM is 
added to git reviewboard, that's where they need to go, but do I need to 
copy the original svn description too?  I'm assuming I do.

The original review was submitted over two weeks go.  Do I need a go 
ahead to commit them?

Allan


More information about the KMyMoney-devel mailing list