[Kmymoney-devel] Re: Review Request: Fix for failure to process correctly an 'L record' with account::sub-account

[Allan Anderson]

> On May 25, 2011, 5:38 a.m., Cristian Onet wrote:
> > It looks alright, and afterall you are the QIF expert :).
> 
> Cristian Onet wrote:
>     And don't forget about the 'BUG: 273950' and the 'REVIEW: 6688' keywords in the commit message :) so that the bug and the review request gets automatically closed.

> It looks alright, and afterall you are the QIF expert :).

No, that's Thomas, I think.  I'm just The Sorcerer's Apprentice!

I'll delay a bit, in case Thomas want's to comment, as I didn't investigate why the original code
didn't work correctly.  Once I had a solution I stopped.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6688/#review10143
-----------------------------------------------------------


On May 25, 2011, 12:10 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6688/
> -----------------------------------------------------------
> 
> (Updated May 25, 2011, 12:10 a.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The account contained in the 'L' record gets passed correctly from
> kmymoney/kmymoney/converter/mymoneyqifreader.cpp to mymoneystatementreader.cpp,
> as 'brokerageaccount'.  There, however, the 'brokerageactid' does not get set
> correctly.  The attached patch appears to fix the problem.
> 
> With the patch applied, an 'L' record of 'L[Bank-Accounts:chq]' will generate
> automatically those two accounts and correctly transfer money into/from
> 'Bank-Accounts:chq' .  However the asset account automatically created is of
> type 'checking'.  So, to achieve what the OP requires, an account of type
> 'asset' first needs to be created.  Then, the required result is obtained.  If
> both the 'Bank-Accounts' and 'chq' accounts are created manually, the same
> result is achieved.
> 
> 
> This addresses bug 273950.
>     https://bugs.kde.org/show_bug.cgi?id=273950
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp 1233480 
> 
> Diff: http://svn.reviewboard.kde.org/r/6688/diff
> 
> 
> Testing
> -------
> 
> Tested with buy, sell and dividend transactions.  Both QIF and CSV imports now
> work correctly.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110525/0cf98523/attachment.htm