<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6688/">http://svn.reviewboard.kde.org/r/6688/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2011, 5:38 a.m., <b>Cristian Onet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks alright, and afterall you are the QIF expert :).</pre>
</blockquote>
<p>On May 25th, 2011, 6:26 a.m., <b>Cristian Onet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And don't forget about the 'BUG: 273950' and the 'REVIEW: 6688' keywords in the commit message :) so that the bug and the review request gets automatically closed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> It looks alright, and afterall you are the QIF expert :).
No, that's Thomas, I think. I'm just The Sorcerer's Apprentice!
I'll delay a bit, in case Thomas want's to comment, as I didn't investigate why the original code
didn't work correctly. Once I had a solution I stopped.
</pre>
<br />
<p>- Allan</p>
<br />
<p>On May 25th, 2011, 12:10 a.m., Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated May 25, 2011, 12:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The account contained in the 'L' record gets passed correctly from
kmymoney/kmymoney/converter/mymoneyqifreader.cpp to mymoneystatementreader.cpp,
as 'brokerageaccount'. There, however, the 'brokerageactid' does not get set
correctly. The attached patch appears to fix the problem.
With the patch applied, an 'L' record of 'L[Bank-Accounts:chq]' will generate
automatically those two accounts and correctly transfer money into/from
'Bank-Accounts:chq' . However the asset account automatically created is of
type 'checking'. So, to achieve what the OP requires, an account of type
'asset' first needs to be created. Then, the required result is obtained. If
both the 'Bank-Accounts' and 'chq' accounts are created manually, the same
result is achieved.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with buy, sell and dividend transactions. Both QIF and CSV imports now
work correctly.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=273950">273950</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(1233480)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6688/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>