[Kmymoney-devel] Re: Review Request: Retain pricing information from manually added transactions

Thomas Baumgart thb at net-bembel.de
Sat May 14 06:59:10 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6674/#review10107
-----------------------------------------------------------



/trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp
<http://svn.reviewboard.kde.org/r/6674/#comment11365>

    You need to use the securities trading currency here. So the code might look like
    
    MyMoneySecurity sec = file->security(account.security);
    
    and the price would use security.tradingCurrency() instead of the baseCurrency.



/trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp
<http://svn.reviewboard.kde.org/r/6674/#comment11364>

    I am not sure where the price source is used other than while displaying entries in the price list editor. I suggest to use a different string here to distinguish between a price entered by the user and one generated from entering a transaction. "Transaction" might be a good one but if you have a better one use it.



/trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp
<http://svn.reviewboard.kde.org/r/6674/#comment11366>

    'file->' == 'MyMoneyFile::instance()' so you can reuse file here.


- Thomas


On May 13, 2011, 4:06 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6674/
> -----------------------------------------------------------
> 
> (Updated May 13, 2011, 4:06 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> At the moment pricing information is retained only from imported transactions.
> 
> This fix is to retain prices entered in manually added or edited transactions.
> 
> 
> This addresses bugs 233236 and Bug.
>     https://bugs.kde.org/show_bug.cgi?id=233236
>     https://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp 1231035 
> 
> Diff: http://svn.reviewboard.kde.org/r/6674/diff
> 
> 
> Testing
> -------
> 
> Astyle run.  Several buy, sell and reinvestment transactions entered/edited.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110514/872d8f8b/attachment.htm 


More information about the KMyMoney-devel mailing list