[Kmymoney-devel] Re: Review Request: Retain pricing information from manually added transactions

[Allan Anderson]

> On May 13, 2011, 8:35 p.m., Cristian Onet wrote:
> > It seems fine to but it's slightly different from entering a transaction in different currencies. When entering a transaction between different currencies there is a per transaction exchange rate (price) which will or will not be added to the prices list depending on the user's choice.
> > But probably in this case it's right to record the price.

Apart from looking at header files, etc., I knew the process works for imports, so I based it on the code in mymoneystatementreader.cpp.

I must admit I was a little surprised at first, but realised that the security price is like the conversion factor to the base currency, I think.

Do you prefer Thomas to give the go-ahead?


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6674/#review10105
-----------------------------------------------------------


On May 13, 2011, 4:06 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6674/
> -----------------------------------------------------------
> 
> (Updated May 13, 2011, 4:06 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> At the moment pricing information is retained only from imported transactions.
> 
> This fix is to retain prices entered in manually added or edited transactions.
> 
> 
> This addresses bugs 233236 and Bug.
>     https://bugs.kde.org/show_bug.cgi?id=233236
>     https://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp 1231035 
> 
> Diff: http://svn.reviewboard.kde.org/r/6674/diff
> 
> 
> Testing
> -------
> 
> Astyle run.  Several buy, sell and reinvestment transactions entered/edited.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110513/6e17cbab/attachment-0001.htm