[Kmymoney-devel] Re: Review Request: Use KComboBox instead of KLineEdit for investment security name use.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6633/#review10030
-----------------------------------------------------------


I simply walked through the code w/o actually using it.


/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
<http://svn.reviewboard.kde.org/r/6633/#comment11270>

    This assumes we all use the 'build' subdirectory to build the application. There is no such requirement and I know of weird people who have the source and the build directories on completely different filesystems. The old version should work well as the current build dir is included in the CMakeLists.txt. If it doesn't for you then try to figure out why.



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp
<http://svn.reviewboard.kde.org/r/6633/#comment11271>

    Please move the return into a separate line.



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp
<http://svn.reviewboard.kde.org/r/6633/#comment11273>

    No need for a return statement here.



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp
<http://svn.reviewboard.kde.org/r/6633/#comment11272>

    You could easily use an else branch here to avoid the mid-function return and thus moving it to the end of the function. Then you can even omit the statement completely.


- Thomas


On March 26, 2011, 6:31 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6633/
> -----------------------------------------------------------
> 
> (Updated March 26, 2011, 6:31 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Previously, it was necessary to type in the name whenever a security was to be imported.  Instead, 
> a KComboBox is used, and security names entered are saved in the resource file, to save inputting 
> each time.  A button has been added to allow removal of any unwanted or erroneous names from the 
> selection list.
> 
> Also, a decimal separator now has to be selected before import, to avoid accidental use of a previous,
> wrong type, which could affect imported values.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1226099 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1226099 
> 
> Diff: http://svn.reviewboard.kde.org/r/6633/diff
> 
> 
> Testing
> -------
> 
> Numerous test files used, plus production files.
> 
> Astyle and Krazy2 run.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110326/212fbe0b/attachment-0001.htm