[Kmymoney-devel] Re: Review Request: Accounts model optimization

[Cristian Onet]

> On March 6, 2011, 3:03 p.m., Alvaro Soliverez wrote:
> > I think the institutions view should be solved via a proxy of the original model. Have you checked that way already? For that, of course, the model only has to reload the changed data and signal that correctly, not reload everything every time.

So far the two hierarchies accounts by type and accounts by institution where side by side in the same model which made things a bit difficult. So I took the decision to split the two hierarchies  into two models.
As for you suggestion to implement a proxy that changes the hierarchy from "by type" to "by institution" I think it would not be straight forward to implement.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6589/#review9960
-----------------------------------------------------------


On March 5, 2011, 9:19 p.m., Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6589/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 9:19 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Instead of synchronizing the whole account tree on each data changed take advantage of the new, more granular, signals and perform the appropriate modifications in the model's data after it has been loaded once.
> 
> Also create a separate instance for the institutions model. This change has the following rationale. Mixing the two hierarchies in the same model (by account type and institution) would make it difficult to implement changes since depending on the changes it would imply structural modifications in only one instance of the same account. So for example changing the institution means a structural change in the institution hierarchy but no change in the accounts by type hierarchy. Separating the two hierarchies means that one account can be found only once in the model and it also simplifies the implementation of the modifications slots.
> 
> 
> This addresses bug 230277.
>     https://bugs.kde.org/show_bug.cgi?id=230277
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.h 1223871 
>   /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp 1223871 
>   /trunk/extragear/office/kmymoney/kmymoney/models/models.h 1223871 
>   /trunk/extragear/office/kmymoney/kmymoney/models/models.cpp 1223871 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp 1223871 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kmymoneyview.cpp 1223871 
> 
> Diff: http://svn.reviewboard.kde.org/r/6589/diff
> 
> 
> Testing
> -------
> 
> Simple testing using a test file: adding/removing/modifying accounts and modifying banances.
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110306/7f883c9b/attachment-0001.htm