<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6589/">http://svn.reviewboard.kde.org/r/6589/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2011, 3:03 p.m., <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the institutions view should be solved via a proxy of the original model. Have you checked that way already? For that, of course, the model only has to reload the changed data and signal that correctly, not reload everything every time.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So far the two hierarchies accounts by type and accounts by institution where side by side in the same model which made things a bit difficult. So I took the decision to split the two hierarchies into two models.
As for you suggestion to implement a proxy that changes the hierarchy from "by type" to "by institution" I think it would not be straight forward to implement.</pre>
<br />
<p>- Cristian</p>
<br />
<p>On March 5th, 2011, 9:19 p.m., Cristian Onet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Cristian Onet.</div>
<p style="color: grey;"><i>Updated March 5, 2011, 9:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of synchronizing the whole account tree on each data changed take advantage of the new, more granular, signals and perform the appropriate modifications in the model's data after it has been loaded once.
Also create a separate instance for the institutions model. This change has the following rationale. Mixing the two hierarchies in the same model (by account type and institution) would make it difficult to implement changes since depending on the changes it would imply structural modifications in only one instance of the same account. So for example changing the institution means a structural change in the institution hierarchy but no change in the accounts by type hierarchy. Separating the two hierarchies means that one account can be found only once in the model and it also simplifies the implementation of the modifications slots.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple testing using a test file: adding/removing/modifying accounts and modifying banances.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=230277">230277</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.h <span style="color: grey">(1223871)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp <span style="color: grey">(1223871)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/models/models.h <span style="color: grey">(1223871)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/models/models.cpp <span style="color: grey">(1223871)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp <span style="color: grey">(1223871)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kmymoneyview.cpp <span style="color: grey">(1223871)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6589/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>