[Kmymoney-devel] Re: Review Request: Allow the resizing of the table in the csv importer plugin

[allan]

On 05/01/11 13:45, Cristian Onet wrote:
> This is an automatically generated e-mail. To reply, visit: 
> http://svn.reviewboard.kde.org/r/6279/
>
>
> Review request for kmymoney.
> By Cristian Onet.
>
>
>   Description
>
> With this patch the size of the table is no longer set programmatically but controlled by the size of the dialog + the imported contents. It seems much better this way. This should be also done for the investments. I removed a bit of code that handled setting the column widths Iif I forgot something please let me know.
>
>
>   Diffs
>
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp
>       (1212010)
>
> View Diff <http://svn.reviewboard.kde.org/r/6279/diff/>
>

I've suspected it for a while, but now I'm pretty sure....  I'm losing 
my grip:(    I had already incorporated the changes to allow stretching 
of the UI, including the table, which can be stretched wider than (my 
1280) screen width to deal with 14 columns at default column width.  
This is so, for both banking and investment screens.

As I said in our chat, two of the hunks in your patches failed, but I 
think I've sorted that.

Looking at the result, though, I have to say I don't like it, I'm 
afraid.  In particular, the table doesn't resize smaller to fit the 
contents, resulting in lots of white space showing.  I see though that 
you're enabling each column to resize to contents, whereas I'd left the 
default setting (which can be stretched), on the grounds that the screen 
wasn't so much for studying, but more just to recognise which columns to 
select for what purpose.

What I'd prefer to do, is to allow automatic column resizing, but to 
keep my table sizing method, complicated though it may be.  Would this 
meet your needs, or have I missed something?

Allan