[Kmymoney-devel] Review Request: Migration to AlkValue

[Carlos da Silva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/
-----------------------------------------------------------

(Updated 2010-09-18 17:15:32.167628)


Review request for kmymoney.


Changes
-------

Updated the code with the latest version of libalkimia.

Now using the String constructor of alkvalue.cpp (commented the string constructor in the mymoneymoney.cpp file).


Summary
-------

Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
The libalkimia, included in the patch, requires the installation of the GMP library (http://gmplib.org/).

Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.

This is an updated version after the fixes in the upstream libalkimia.


This addresses bug 245214.
    https://bugs.kde.org/show_bug.cgi?id=245214


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1176772 
  /trunk/extragear/office/kmymoney/libalkimia/CMakeLists.txt PRE-CREATION 
  /trunk/extragear/office/kmymoney/libalkimia/alkvalue.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/libalkimia/alkvalue.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5310/diff


Testing
-------

All unit tests present in the code.
Tested with two of my real files, and the files posted in the bug description.


Thanks,

Carlos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100918/416cd33e/attachment.htm