[Kmymoney-devel] Review Request: Migration to AlkValue

[Jose Villanova]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/#review7631
-----------------------------------------------------------

Ship it!


Hi Carlos.

I've made my tests and so far it's working without any problem.

I used revision r1175575 to test it

- Jose


On 2010-09-13 17:13:45, Carlos da Silva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5310/
> -----------------------------------------------------------
> 
> (Updated 2010-09-13 17:13:45)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
> The libalkimia, included in the patch, requires the installation of the GMP library (http://gmplib.org/).
> 
> Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.
> 
> This is an updated version after the fixes in the upstream libalkimia.
> 
> 
> This addresses bug 245214.
>     https://bugs.kde.org/show_bug.cgi?id=245214
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1174934 
>   /trunk/extragear/office/kmymoney/libalkimia/CMakeLists.txt PRE-CREATION 
>   /trunk/extragear/office/kmymoney/libalkimia/alkvalue.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/libalkimia/alkvalue.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5310/diff
> 
> 
> Testing
> -------
> 
> All unit tests present in the code.
> Tested with two of my real files, and the files posted in the bug description.
> 
> 
> Thanks,
> 
> Carlos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100916/5998c092/attachment.htm