[Kmymoney-devel] Review Request: Allow payee editing using double click, F2 or the context menu

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5340/#review7611
-----------------------------------------------------------

Ship it!


It works here.

- Alvaro


On 2010-09-14 12:33:29, Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5340/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 12:33:29)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This patch tries to resolve the problem which seems to be caused by the flag "m_inPayeeEditing". The patch reverses the logic so that editing is only suppressed in certain circumstances and allowed in all others.
> 
> This patch is against trunk. Once confirmed, it should be backported to the 4.5 branch.
> 
> 
> This addresses bug 251212.
>     https://bugs.kde.org/show_bug.cgi?id=251212
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.h 1175178 
>   trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.cpp 1175178 
> 
> Diff: http://svn.reviewboard.kde.org/r/5340/diff
> 
> 
> Testing
> -------
> 
> I tested this against my current file. No unit tests involved.
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100915/b429a240/attachment.htm