[Kmymoney-devel] Review Request: Migration to AlkValue

[Carlos da Silva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/
-----------------------------------------------------------

Review request for kmymoney.


Summary
-------

Need help in porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
The libalkimia, included in the patch, requires the installation of the GMP library (http://gmplib.org/).

Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.

I need some help with the string constructor.
It works for the string "0.07", but it does not work for the string "0.08".
The examples are in the mymoneymoneytest.cpp file.


This addresses bug 245214.
    https://bugs.kde.org/show_bug.cgi?id=245214


Diffs
-----

  /trunk/extragear/office/kmymoney/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1174271 
  /trunk/extragear/office/kmymoney/libalkimia/CMakeLists.txt PRE-CREATION 
  /trunk/extragear/office/kmymoney/libalkimia/alkvalue.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/libalkimia/alkvalue.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5310/diff


Testing
-------

All unit tests present in the code.
Created a new test in the mymoneymoneytest.cpp to show where is the problem.


Thanks,

Carlos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100911/578ea378/attachment.htm