[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Allan Anderson]

> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp, line 332
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34758#file34758line332>
> >
> >     remove qDebug statements

I'd left those in as progress indicators, but will remove them last thing.


> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui, line 698
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34759#file34759line698>
> >
> >     When possible, use KDE classes for the UI. In this case, use KPushButton

All changed.


> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h, line 45
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34763#file34763line45>
> >
> >     same as above, it would be better to subclass the ui

Done.


> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h, line 108
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34763#file34763line108>
> >
> >     Same as above

Done.


> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.ui, line 690
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34765#file34765line690>
> >
> >     same comment as previous .ui

Done.


> On 2010-08-29 23:38:39, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp, line 37
> > <http://svn.reviewboard.kde.org/r/5162/diff/1/?file=34769#file34769line37>
> >
> >     remove qDebug statements

Will do.  I've not yet updated the patches as I need to redo something.  I have, deliberately, used recursive code for re-checking any alterations made by the user to investment activity types.  It recurses for each attempt he makes, so shouldn't get out of control, but I'm going to look again at the code.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/#review7280
-----------------------------------------------------------


On 2010-09-11 10:44:59, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> 
> (Updated 2010-09-11 10:44:59)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.
> 
> Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.
> 
> As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?
> 
> Apart from functioning as a plugin, it also can produce QIF files if required.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5162/diff
> 
> 
> Testing
> -------
> 
> I've run Krazy2 and astyle against it, also unit test.  
> 
> Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.
> 
> 
> Screenshots
> -----------
> 
> KListWidget version
>   http://svn.reviewboard.kde.org/r/5162/s/501/
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100911/bb5d9013/attachment-0001.htm