[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/
-----------------------------------------------------------

(Updated 2010-09-07 17:44:53.714263)


Review request for kmymoney.


Changes
-------

This diff takes into account all the criticisms/suggestions made regarding the last revision.
In addition, I have revised RedefineDlg class, to avoid the recursive call, which was used to re-check changes made by the user.  Now, The user is presented only with legitimate investment activity types matching the imported transaction, avoiding the need for re-checking.
Changes made elsewhere are fairly minor.
Hopefully, this is getting close.


Summary
-------

This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.

Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.

As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?

Apart from functioning as a plugin, it also can produce QIF files if required.


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1172628 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterrc PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.desktop PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.rc PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/nogo.png UNKNOWN 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/tick.png UNKNOWN 

Diff: http://svn.reviewboard.kde.org/r/5162/diff


Testing
-------

I've run Krazy2 and astyle against it, also unit test.  

Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.


Thanks,

Allan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100907/d30f135d/attachment.htm