[Kmymoney-devel] Re: Review Request: Switch to AqBanking 5.0

[Cristian Onet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5524/#review8671
-----------------------------------------------------------

Ship it!


The patch fails to apply to trunk.
Hunk #20 FAILED at 898.
Hunk #21 FAILED at 960.
2 out of 21 hunks FAILED -- saving rejects to file kmymoney/plugins/kbanking/mymoneybanking.cpp.rej
I'd say commit it to trunk since there is no harm in that.

- Cristian


On 2010-10-04 06:23:18, Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5524/
> -----------------------------------------------------------
> 
> (Updated 2010-10-04 06:23:18)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> With this path applied, one can build the KBanking plugin against AqBanking5 and Gwenhywfar4
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/cmake/modules/FindAqBanking.cmake 1181817 
>   trunk/extragear/office/kmymoney/cmake/modules/FindGwenhywfar.cmake 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/CMakeLists.txt 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/banking.hpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/banking.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/CMakeLists.txt 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.ui PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbpickstartdate.h 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbpickstartdate.cpp 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbsettings.h 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbsettings.cpp 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/kbanking.h 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/kbanking.cpp 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.h 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.cpp 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/views/kbjobview.h 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/views/kbjobview.cpp 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/CMakeLists.txt 1181817 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/kbaccountlist.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/kbaccountlist.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5524/diff
> 
> 
> Testing
> -------
> 
> Tested in my local environment against the institutions I have accounts with
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101111/b721cb09/attachment.htm