<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5524/">http://svn.reviewboard.kde.org/r/5524/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch fails to apply to trunk.
Hunk #20 FAILED at 898.
Hunk #21 FAILED at 960.
2 out of 21 hunks FAILED -- saving rejects to file kmymoney/plugins/kbanking/mymoneybanking.cpp.rej
I'd say commit it to trunk since there is no harm in that.</pre>
<br />
<p>- Cristian</p>
<br />
<p>On October 4th, 2010, 6:23 a.m., Thomas Baumgart wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Thomas Baumgart.</div>
<p style="color: grey;"><i>Updated 2010-10-04 06:23:18</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this path applied, one can build the KBanking plugin against AqBanking5 and Gwenhywfar4</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in my local environment against the institutions I have accounts with</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/office/kmymoney/cmake/modules/FindAqBanking.cmake <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/cmake/modules/FindGwenhywfar.cmake <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/CMakeLists.txt <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/banking.hpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/banking.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/CMakeLists.txt <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbmapaccount.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbpickstartdate.h <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbpickstartdate.cpp <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbsettings.h <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/dialogs/kbsettings.cpp <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/kbanking.h <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/kbanking.cpp <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.h <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.cpp <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/views/kbjobview.h <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/views/kbjobview.cpp <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/CMakeLists.txt <span style="color: grey">(1181817)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/kbaccountlist.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/widgets/kbaccountlist.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5524/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>