[Kmymoney-devel] Report settings page

[Alvaro Soliverez]

On Sun, May 16, 2010 at 10:52 PM, Alvaro Soliverez <asoliverez at gmail.com> wrote:
> On Sun, May 16, 2010 at 5:54 PM, Bernd Gonsior
> <bernd.gonsior at googlemail.com> wrote:
>> Alvaro Soliverez schrieb am 09.05.2010 17:10:
>>> Hello Bernd,
>>> A couple of comments:
>>> - make the report settings page a new one, like Forecast or Home
>>> settings, so we can throw all settings there, instead of adding a new
>>> tab to General.
>>
>> Done. The archive ksettingsreports.tgz contains a diff for the modified,
>> existing files:
>>
>> kmymoney/kmymoney.kcfg
>> kmymoney/reports/reporttable.cpp
>> kmymoney/reports/reporttable.h
>> kmymoney/dialogs/settings/CMakeLists.txt
>> kmymoney/kmymoney.cpp
>>
>> and it contains the new files complete:
>>
>> kmymoney/dialogs/settings/ksettingsreportsdecl.ui
>> kmymoney/dialogs/settings/ksettingsreports.h
>> kmymoney/dialogs/settings/ksettingsreports.cpp
>>
>> I added some checks for the css file. If these do not fit somehow, i can
>> easily remove them. If you have further remarks, simply tell me.
>>
>> Regards,
>> Bernd
>>
>> BTW:
>> my english (for lables or messages) should be checked
>>
> Hello Bernd,
> It looks very good.
>
> The only comment I have is on the usage of i18n for plural messages.
> Line 87 to 91 of ksettingsreport.cpp can be simplified by using i18np,
> which accepts messages for singular and plural.
>
> The rest is ok. I'll keep the patch here and submit it as soon as we
> clear some bug that will probably trigger a new release and we don't
> want any new strings in.
>

I've commited the patch.

I've made some changes, which you would like to review.
- Changed i18n to i18np for strings with plural messages
- Changed naming of internal variables to a more descriptive name (no
three-letter names, please ;) )
- Changed case and the wording of the settings label a little. Also
added a descriptive message for the legend setting
- Removed the KTabWidget from the settings .ui file, since it wasn't
needed in this case (there was only one tab)

Thanks a lot for your contribution!

Regards,
Alvaro