[Kmymoney-devel] Review Request: Allan's csvimporter plugin

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4462/#review6303
-----------------------------------------------------------



trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h
<http://reviewboard.kde.org/r/4462/#comment5982>

    No public members, please. And respect the naming scheme. Properties of a class should be called m_<name>



trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp
<http://reviewboard.kde.org/r/4462/#comment5983>

    As I think Cristian, these should be properties of the class, and the value set on initialization, not on the body of the constructor.



trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h
<http://reviewboard.kde.org/r/4462/#comment5984>

    Rename it to m_conv. It could also use a more descriptive name.



trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
<http://reviewboard.kde.org/r/4462/#comment5986>

    use #include <KSharedConfig> and #include <KMessageBox> instead



trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui
<http://reviewboard.kde.org/r/4462/#comment5985>

    Use QLayouts instead of fixed positions. This does not play well with different resolutions


- Alvaro


On 2010-06-27 03:49:22, Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4462/
> -----------------------------------------------------------
> 
> (Updated 2010-06-27 03:49:22)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Allan's csvimporter plugin
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1143143 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.ui PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.desktop PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.rc PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp PRE-CREATION 
>   trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4462/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100628/9a978cfa/attachment-0001.htm