<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4462/">http://reviewboard.kde.org/r/4462/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4462/diff/1/?file=29800#file29800line37" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <span class="kt">int</span> <span class="n">dtFormat</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">No public members, please. And respect the naming scheme. Properties of a class should be called m_<name></pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4462/diff/1/?file=29801#file29801line31" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">int pass;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="n">QString</span> <span class="n">dateFmat</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">As I think Cristian, these should be properties of the class, and the value set on initialization, not on the body of the constructor.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4462/diff/1/?file=29802#file29802line42" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <span class="n">CnvDate</span><span class="o">*</span> <span class="n">conv</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">Rename it to m_conv. It could also use a more descriptive name.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4462/diff/1/?file=29805#file29805line33" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="cp">#include "ksharedconfig.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">use #include <KSharedConfig> and #include <KMessageBox> instead</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4462/diff/1/?file=29806#file29806line31" style="color: black; font-weight: bold; text-decoration: underline;">trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <x>4</x></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">Use QLayouts instead of fixed positions. This does not play well with different resolutions</pre>
</div>
<br />
<p>- Alvaro</p>
<br />
<p>On June 27th, 2010, 3:49 a.m., Cristian Onet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Cristian Onet.</div>
<p style="color: grey;"><i>Updated 2010-06-27 03:49:22</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Allan's csvimporter plugin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt <span style="color: grey">(1143143)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4462/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>