[Kmymoney-devel] Review Request: Check for duplicate transactionid entries in Consistency Check

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4772/#review6735
-----------------------------------------------------------


I may be wrong, but to me it looks like the patch relies on the transactions being sorted by id. Otherwise, I don't see how it could find duplicate transactions if they are further apart in the QList.
Are transactions really sorted by id, or just in the order they are in the file, or the entry date?

- Alvaro


On 2010-07-29 02:47:29, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4772/
> -----------------------------------------------------------
> 
> (Updated 2010-07-29 02:47:29)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This patch attempts to repair files that have transactions with duplicate transactionid entries. It is posted here because of the additional string during pre-release string-freeze.
> 
> BUG: 246108
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.cpp 1156373 
> 
> Diff: http://reviewboard.kde.org/r/4772/diff
> 
> 
> Testing
> -------
> 
> I created a .kmy file with a duplicate transactionid. Then I ran consistency check and saved the file. The one of the two transactions in conflict had a new id.
> 
> The consistency check result dialog showed that 1 duplicate transactionid issue had been resolved.
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100729/ea7c100d/attachment-0001.htm