<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4772/">http://reviewboard.kde.org/r/4772/</a>
</td>
</tr>
</table>
<br />
<pre>I may be wrong, but to me it looks like the patch relies on the transactions being sorted by id. Otherwise, I don't see how it could find duplicate transactions if they are further apart in the QList.
Are transactions really sorted by id, or just in the order they are in the file, or the entry date?</pre>
<br />
<p>- Alvaro</p>
<br />
<p>On July 29th, 2010, 2:47 a.m., Fernando Vilas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>
<p style="color: grey;"><i>Updated 2010-07-29 02:47:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch attempts to repair files that have transactions with duplicate transactionid entries. It is posted here because of the additional string during pre-release string-freeze.
BUG: 246108</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">I created a .kmy file with a duplicate transactionid. Then I ran consistency check and saved the file. The one of the two transactions in conflict had a new id.
The consistency check result dialog showed that 1 duplicate transactionid issue had been resolved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(1156373)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>