[Kmymoney-devel] Review Request: Ported kreportsview to QT4.

[Alvaro Soliverez]

> On 2010-07-12 02:56:54, Alvaro Soliverez wrote:
> > I tested the patch and from a functional point of view, it looks ok, or at least nothing is extremely wrong.
> > Once you go over the issues I mentioned, we'll commit it.
> > There may be some minor issues, but we can go over them in SVN.
> 
> Bernd Gonsior wrote:
>     There are some old qDebug statements, should i replace them with qWarning too or not?
>     
>     BTW:
>     When configuring a report the expected 'OK'-button is labeled
>     'Suche' (= 'search' in german). The tooltip is OK, it is
>     'Aenderungen anwenden' (= 'apply').
>

If they were there before, just remove them, unless you think the warnings are really needed, in which case replace them with qWarning.

The label is because that dialog is shared with the find transactions dialog. No problem with that.


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4601/#review6483
-----------------------------------------------------------


On 2010-07-12 16:28:16, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4601/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 16:28:16)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> See inline-doc (doxygen). This patch should be tested careful before it is commited to svn.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.cpp 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/CMakeLists.txt 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.h 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100712/c276bf06/attachment-0001.htm