<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4601/">http://reviewboard.kde.org/r/4601/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2010, 2:56 a.m., <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I tested the patch and from a functional point of view, it looks ok, or at least nothing is extremely wrong.
Once you go over the issues I mentioned, we'll commit it.
There may be some minor issues, but we can go over them in SVN.</pre>
</blockquote>
<p>On July 12th, 2010, 4:36 p.m., <b>Bernd Gonsior</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>There are some old qDebug statements, should i replace them with qWarning too or not?
BTW:
When configuring a report the expected 'OK'-button is labeled
'Suche' (= 'search' in german). The tooltip is OK, it is
'Aenderungen anwenden' (= 'apply').
</pre>
</blockquote>
</blockquote>
<pre>If they were there before, just remove them, unless you think the warnings are really needed, in which case replace them with qWarning.
The label is because that dialog is shared with the find transactions dialog. No problem with that.</pre>
<br />
<p>- Alvaro</p>
<br />
<p>On July 12th, 2010, 4:28 p.m., Bernd Gonsior wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Bernd Gonsior.</div>
<p style="color: grey;"><i>Updated 2010-07-12 16:28:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">See inline-doc (doxygen). This patch should be tested careful before it is commited to svn.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.cpp <span style="color: grey">(1148947)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/CMakeLists.txt <span style="color: grey">(1148947)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.h <span style="color: grey">(1148947)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4601/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>