[Kmymoney-devel] Review Request: Ported kreportsview to QT4.

[Bernd Gonsior]

> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h, line 20
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30882#file30882line20>
> >
> >     Are STL headers in use here?

Removed.


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp, line 42
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30883#file30883line42>
> >
> >     Can you add some comments on what this method does?

Linked documentation of TocItem::operator from .cpp to .h.


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp, line 57
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30883#file30883line57>
> >
> >     Please remove qDebug statements or comment them. if it's an irregular situation, try to recover in a graceful way, add an assert or an exception

- removed unnecessary debug messages
- added KMessageBox::error where it is necessary to inform the user about error conditions


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h, line 21
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30884#file30884line21>
> >
> >     Are STL headers included here?

Removed.


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h, line 35
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30884#file30884line35>
> >
> >     Is this needed in this case?

Removed.


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h, line 21
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30886#file30886line21>
> >
> >     Is this needed? I don't STL headers being used here

Removed.


> On 2010-07-11 18:58:36, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h, line 35
> > <http://reviewboard.kde.org/r/4601/diff/2/?file=30886#file30886line35>
> >
> >     Is this include really needed?

Removed.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4601/#review6480
-----------------------------------------------------------


On 2010-07-11 17:59:05, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4601/
> -----------------------------------------------------------
> 
> (Updated 2010-07-11 17:59:05)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> See inline-doc (doxygen). This patch should be tested careful before it is commited to svn.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/views/CMakeLists.txt 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.h 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.cpp 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100712/5be4a9d9/attachment.htm