[Kmymoney-devel] Review Request: Ported kreportsview to QT4.

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4601/#review6480
-----------------------------------------------------------


I know there must be some comments on code which was already there and you only copy+pasted.

As soon as I commit what I'm doing I'll give it a try.

Good work!


/trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h
<http://reviewboard.kde.org/r/4601/#comment6221>

    Are STL headers in use here?



/trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp
<http://reviewboard.kde.org/r/4601/#comment6219>

    Can you add some comments on what this method does?



/trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp
<http://reviewboard.kde.org/r/4601/#comment6220>

    Please remove qDebug statements or comment them. if it's an irregular situation, try to recover in a graceful way, add an assert or an exception



/trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h
<http://reviewboard.kde.org/r/4601/#comment6218>

    Are STL headers included here?



/trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h
<http://reviewboard.kde.org/r/4601/#comment6217>

    Is this needed in this case?



/trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h
<http://reviewboard.kde.org/r/4601/#comment6216>

    Is this needed? I don't STL headers being used here



/trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h
<http://reviewboard.kde.org/r/4601/#comment6215>

    Is this include really needed?


- Alvaro


On 2010-07-11 17:59:05, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4601/
> -----------------------------------------------------------
> 
> (Updated 2010-07-11 17:59:05)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> See inline-doc (doxygen). This patch should be tested careful before it is commited to svn.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/views/CMakeLists.txt 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.h 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.cpp 1148689 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100711/255d1dca/attachment-0001.htm