[Kmymoney-devel] Review Request: Q3Wizard->QWizard port of Loan Wizards

Fernando Vilas fvilas at iname.com
Sun Jul 11 22:27:05 CEST 2010 


> On 2010-07-11 17:37:18, Alvaro Soliverez wrote:
> > Can you explain a bit further what you did? There seem to be a lot of new files...

Each page became its own class, so a new .h/.cpp/.ui for each of them. That explains all the new files. I also tried to push as much of the logic as I could into the pages, instead of the main wizard. That seems to be the way that the Qt4 version of QWizard wants things.


- Fernando


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4588/#review6479
-----------------------------------------------------------


On 2010-07-11 03:13:10, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4588/
> -----------------------------------------------------------
> 
> (Updated 2010-07-11 03:13:10)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Port KNewLoanWizard and KEditLoanWizard to QWizard from Q3Wizard
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneyedit.h 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/CMakeLists.txt 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.h 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.cpp 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.h 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui 1148527 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpagedecl.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpagedecl.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4588/diff
> 
> 
> Testing
> -------
> 
> This seems to work for me, but it is far too big of a wizard to be confident that I got all cases. Any additional testing would be appreciated. Then we can commit to SVN when it is ready for a larger audience.
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100711/61a4462a/attachment-0001.htm

More information about the KMyMoney-devel mailing list