<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4588/">http://reviewboard.kde.org/r/4588/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 11th, 2010, 5:37 p.m., <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Can you explain a bit further what you did? There seem to be a lot of new files...</pre>
</blockquote>
</blockquote>
<pre>Each page became its own class, so a new .h/.cpp/.ui for each of them. That explains all the new files. I also tried to push as much of the logic as I could into the pages, instead of the main wizard. That seems to be the way that the Qt4 version of QWizard wants things.</pre>
<br />
<p>- Fernando</p>
<br />
<p>On July 11th, 2010, 3:13 a.m., Fernando Vilas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>
<p style="color: grey;"><i>Updated 2010-07-11 03:13:10</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Port KNewLoanWizard and KEditLoanWizard to QWizard from Q3Wizard</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This seems to work for me, but it is far too big of a wizard to be confident that I got all cases. Any additional testing would be appreciated. Then we can commit to SVN when it is ready for a larger audience.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneyedit.h <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/CMakeLists.txt <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/additionalfeeswizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/assetaccountwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/calculationoverviewwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editintrowizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/effectivedatewizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/finalpaymentwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/firstpaymentwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcalculationwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestcategorywizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesteditwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interesttypewizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/interestwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.h <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.cpp <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.h <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui <span style="color: grey">(1148527)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/lendborrowwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/loanamountwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/namewizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newcalculateloanwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newgeneralinfowizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newintrowizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/newpaymentswizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymenteditwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/previouspaymentswizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/recordpaymentwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/schedulewizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/variableinterestdatewizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4588/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>