[Kmymoney-devel] Can't remove payee from transaction (3.95)

[Thomas Baumgart]

Hi,

on Friday 19 February 2010 Jack wrote:


> On 2010.02.19 07:20, Alvaro Soliverez wrote:
> > On Thu, Feb 18, 2010 at 11:34 AM, Alvaro Soliverez
> >
> > <asoliverez at gmail.com> wrote:
> > > On Thu, Feb 18, 2010 at 11:12 AM, Jack
> >
> > <ostroffjh at users.sourceforge.net> wrote:
> > >> On 2010.02.18 01:00, Thomas Baumgart wrote:
> > >>> on Wednesday 17 February 2010 Alvaro Soliverez wrote:
> > >>>
> >>>>> On Wed, Feb 17, 2010 at 2:55 PM, Jack
> >>>>>
> >>>>> <ostroffjh at users.sourceforge.net wrote:
> >>>>>> For transfer transactions, I prefer not to specify a Payee.  I
> >>>>>> can create such a transaction with no problem.  However, when I
> >>>>>> download an OFX from my bank, a transfer shows up as a payment,
> >>>>>> and I used to (in 1.0) edit the transacion, delete the payee,
> >>>>>> change the transaction type to transfer, and add the other
> >>>>>> account.  In the new version, I do exactly the same thing, but
> >>>>>> when I save the transaction, the payee is still there.
> >>>>>>
> >>>>>> There is another minor difference between 1.0 and 3.95, although
> >>>>>> this is from memory since I don't have a copy of the old version
> >>>>>> installed. In 1.0, I had to explicitly hit ESC or click in
> >>>>>> another field when leaving the Payee field blank, or else it
> >>>>>> would just insert whatever payee was selected in the drop-down.
> >>>>>>  In 3.95, I can just tab out of a blank payee field - which is
> >>>>>> fine for a new transaction, but if I'm deleting a payee when
> >>>>>> editing a transaction, it shows a blank payee field, but it
> >>>>>> doesn't actually delete it, and the original payee shows up
> >>>>>> after I have saved the transaction.
> >>>>>
> >>>>> This is probably a problem with the new KMyMoneyPayeeCombo. I'll
> >>>>> look into  it.
> >>>>>
> > >>> Looks very similar to https://bugs.kde.org/show_bug.cgi?id=226261
> >>>
> >>> This is not the same as that bug.  I am not trying to completely
> >>> delete the payee.  I am just trying to remove the payee from the
> >>> transaction. I can see this happening if the KMyMoneyPayeeCombo
> >>> returns "no change" rather than "changed to blank" so I think
> >>> Alvaro is probably on the right track.
> >>
> >> There's a condition in the code where it specifically prevents you
> >> from putting a blank on an existing payee. :D
> >>
> > > I have to run some tests and then I'll commit the fix.
> >
> > can you try the latest svn? I added a condition to check for that
> > case.
> 
> Alvaro,
> 
> Your patch works.  Sorry for the false alarm.  I'm still not sure if
> the test failed because I was trying to test using kmymoney.shell and
> not doing "make install" or if I really didn't have a sufficiently
> recent svn.

Just tried the following to see what happens:

a) installed KMymoney
b) modified payee object to spit out a debug message in its ctor
c) compiled KMyMoney (no make install)
d) ran kmymoney/kmymoney.shell to start it
e) verified that the debug message gets printed once I start the transaction 
editor

and sure it does. So your test method was OK and the problem must have been in 
another spot.

> Thanks for the effort.

Thanks for the feedback.

-- 


Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Computer science terms (#095): PGP-Keysigning-Party
 The cult of sitting together and collectively mumbling magic numbers.
 -- Gert Doering
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 224 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100220/6950634d/attachment.sig