[Kmymoney-devel] Re: Review Request: csvplugin update to add additional unit test, and improve field delimiter handling

[Allan Anderson]

> On 2010-12-01 13:07:54, Cristian Onet wrote:
> > I forgot the shipt it flag.
> 
> Allan Anderson wrote:
>     Cristian
>     When I went to commit yesterday, there was showing a conflict on csvimporterdlg.cpp with a commit of yours.  I went through the resolve procedure, but I could see only the previous version.
>     
>     Perhaps you may need to check?
>     Allan
> 
> Cristian Onet wrote:
>     I only committed whitespace changes to plugins/csvimport yesterday due to running kmymoney-astyle.sh. So there is no need for me to check it since it was only whitespace. Sorry for conflicting with your work.

I'd already done that!  It explains why I couldn't see anything.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5463/#review9075
-----------------------------------------------------------


On 2010-11-30 00:19:35, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated 2010-11-30 00:19:35)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The initial intention was to add an additional unit test, which involved removing data line parsing from the displayLine() routine into a small separate class to enable access from the unit test routine.  This led to benefits in two other areas.  
> 
> One csv test file I have had a comma as thousand separator, which was conflicting with the comma field separator.  Initially, I looked at this from the point of view of field separators and concocted a separator which successfully dealt with the issue.  However, I realised that the same odd separator might not work in another similar situation.  So, I've improved the detection and handling of this issue.
> 
> This then led to changes in csvProcessing() and investProcessing(), removing redundant code and improving efficiency slightly.
> 
> Two UIs have had a now unneeded field separator combobox item removed.  Some minor purely cosmetic changes also have been made.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1202162 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1202162 
> 
> Diff: http://svn.reviewboard.kde.org/r/5463/diff
> 
> 
> Testing
> -------
> 
> The new parsedatatest() unit test runs successfully.  Krazy and astyle have been run. Functional testing done with various csv format files.
> 
> Also, built and tested on a Ubuntu box, as well as openSuse. 800x600 and 1280x1024 resolutions checked, and different font sizes tested.
> 
> In use for my production.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101202/f35b15d6/attachment.htm