[Kmymoney-devel] Re: Review Request: CSVImporter Plugin for KMyMoney

[Cristian Onet]

> On 2010-09-14 13:21:51, Alvaro Soliverez wrote:
> > Mark this review as commited please.
> 
> Allan Anderson wrote:
>     This review update has been committed.

But the review request is still not marked as committed. You can do that in the menu on the top right where you also have 'Download diff', and 'Review' options.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/#review7600
-----------------------------------------------------------


On 2010-09-14 12:56:58, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 12:56:58)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.
> 
> Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.
> 
> As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?
> 
> Apart from functioning as a plugin, it also can produce QIF files if required.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1175183 
> 
> Diff: http://svn.reviewboard.kde.org/r/5162/diff
> 
> 
> Testing
> -------
> 
> I've run Krazy2 and astyle against it, also unit test.  
> 
> Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.
> 
> 
> Screenshots
> -----------
> 
> KListWidget version
>   http://svn.reviewboard.kde.org/r/5162/s/501/
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101201/0408243f/attachment.htm