[Kmymoney-devel] KMyMoney: proposal to replace hard coded utf-8 in KReportsView::KReportTab

[Alvaro Soliverez]

Hello Bernd,
the patches were ok. I only made a few changes and they are now
commited into SVN.
Thanks for the hard work!

Regards,
Alvaro

On Sun, Apr 18, 2010 at 6:48 PM, Bernd Gonsior <bgo at freeplexx.de> wrote:
> Hello Alvaro,
>
> here are the patches for review.
>
> 1. includecss_checkbox.tgz
>
> 2. separate_html.tgz
>
> 3. both_combined.tgz
>
> Some remarks:
>
> The parameterlist for renderHTML is a bit long now:
>
> QString reports::ReportTable::renderHTML(QWidget* widget,
>    const QByteArray& encoding, const QString& title, bool includeCSS)
>
> 'includeCSS' is user's choice, 'encoding' could be user's choice some day,
> 'widget' and 'title' could be set at another, central location (perhaps a
> constructor) but i did not want to modify the existing sources too much.
>
> When merging both patches in my sandbox there were some merge conflicts which
> i solved manually. That's why i would recommend to use the 'both_combined'
> patch.
>
> Regards,
> Bernd
>