[Kmymoney-devel] KMyMoney: proposal to replace hard coded utf-8 in KReportsView::KReportTab

[Bernd Gonsior]

Hello Alvaro,

here are the patches for review.

1. includecss_checkbox.tgz

2. separate_html.tgz

3. both_combined.tgz

Some remarks:

The parameterlist for renderHTML is a bit long now:

QString reports::ReportTable::renderHTML(QWidget* widget,
    const QByteArray& encoding, const QString& title, bool includeCSS)

'includeCSS' is user's choice, 'encoding' could be user's choice some day,
'widget' and 'title' could be set at another, central location (perhaps a
constructor) but i did not want to modify the existing sources too much.

When merging both patches in my sandbox there were some merge conflicts which
i solved manually. That's why i would recommend to use the 'both_combined'
patch.

Regards,
Bernd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: both_combined.tgz
Type: application/x-compressed-tar
Size: 57097 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100418/56ce3ac9/attachment-0003.tgz 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: includecss_checkbox.tgz
Type: application/x-compressed-tar
Size: 12462 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100418/56ce3ac9/attachment-0004.tgz 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: separate_html.tgz
Type: application/x-compressed-tar
Size: 55032 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100418/56ce3ac9/attachment-0005.tgz