[Kmymoney-devel] KMyMoney: proposal to replace hard coded utf-8 in KReportsView::KReportTab

[Alvaro Soliverez]

On Wed, Mar 31, 2010 at 8:14 PM, aga <aganderson at ukonline.co.uk> wrote:
> On Wednesday 31 Mar 2010 03:14:07 Alvaro Soliverez wrote:
>> On Tue, Mar 30, 2010 at 6:47 AM, Bernd Gonsior <bgo at freeplexx.de> wrote:
>> >> Now, for a more permanent fix of this issue, I'd like to move the
>> >> whole HTML generation code to a separate class. That would move a lot
>> >> of code which doesn't really belong to the view out of the main class.
>> >> Would you like to take on that?
>> >>
>> >> Regards,
>> >> Alvaro
>> >
>> > If there is some time to do that, yes, i can do. The HTML
>> > generation code seems to be a bit
>> > distributed (PivotTable::renderHTML, ListTable::renderHTML,
>> > KReportsView::KReportTab::createTable) and is sometimes mixed
>> > with csv generation. Would you like to have a HTML generation class
>> > for KReportsView only or something more general? When should it
>> > be done?
>>
>> Hello Berndt,
>> Both PivotTable and ListTable inherit ReportTable, which currently
>> serves as interfaces for both. Since this code is common to both
>> classes, I think it should go into that class. The next freeze in on
>> April 30th, so you have until then, if you are interested.
>>
>> The html code in PivotTable and ListTable is not to be touched at this
>> point. It's fairly complex, they do different stuff in different ways,
>> and I wouldn't like to mess with it at this point in the lifecycle.
>>
>> Regards,
>> Alvaro
>
> Just thought I'd mention it, in case this is an opportune time.  If this is in
> the area to be reworked, might it be possible to look at an earlier suggestion
> that the headings on reports be locked, so as not to scroll out of sight?
>

No, that's not within the scope of this change. Actually, no feature
is being changed, it's just code being moved around.
In time, it will make those changes easier.