Review Request 129898: Fix: activate "next/previous layer" shorcut for layers or group which are invisible.

[Aniketh Girish]

> On Jan. 28, 2017, 3:33 p.m., Dmitry Kazakov wrote:
> > Could you tell what does this patch do? As far as I can see from the patch, it basically disables the isEditable() check, because (!A || A) is always true.
> > 
> > And please next time use https://phabricator.kde.org/differential/ for Krita patches.

Damn! What I did is really wrong. Sorry. My bad. So, As of now what I see is that, the condition should return true value to engage the working of the shortcuts. So why do we need to check if that node is isEditable() or not. Even its not editable we should be able to enter that group right? Will creating a condition inside the "while" loop and the existing condition "if" to check if the node is not isEditable() to return the required output ?

Also sorry for posting the review request over here. As I am unable to authenticate to phabricator with my KDE identity credentials.


- Aniketh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129898/#review102303
-----------------------------------------------------------


On Jan. 28, 2017, 2:16 p.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129898/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2017, 2:16 p.m.)
> 
> 
> Review request for Krita Extensions and Boudewijn Rempt.
> 
> 
> Bugs: 336899
>     https://bugs.kde.org/show_bug.cgi?id=336899
> 
> 
> Repository: krita
> 
> 
> Description
> -------
> 
> use PgDn, PgUp as shortcuts to move through the invisible layers inside a group.
> 
> 
> Diffs
> -----
> 
>   libs/ui/kis_node_manager.cpp 9dba112 
> 
> Diff: https://git.reviewboard.kde.org/r/129898/diff/
> 
> 
> Testing
> -------
> 
> Checked by building it.
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20170128/8076bfa0/attachment.html>