Review Request 129898: Fix: activate "next/previous layer" shorcut for layers or group which are invisible.

Dmitry Kazakov dimula73 at gmail.com
Sat Jan 28 15:33:26 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129898/#review102303
-----------------------------------------------------------



Could you tell what does this patch do? As far as I can see from the patch, it basically disables the isEditable() check, because (!A || A) is always true.

And please next time use https://phabricator.kde.org/differential/ for Krita patches.

- Dmitry Kazakov


On Jan. 28, 2017, 2:16 p.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129898/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2017, 2:16 p.m.)
> 
> 
> Review request for Krita Extensions and Boudewijn Rempt.
> 
> 
> Bugs: 336899
>     https://bugs.kde.org/show_bug.cgi?id=336899
> 
> 
> Repository: krita
> 
> 
> Description
> -------
> 
> use PgDn, PgUp as shortcuts to move through the invisible layers inside a group.
> 
> 
> Diffs
> -----
> 
>   libs/ui/kis_node_manager.cpp 9dba112 
> 
> Diff: https://git.reviewboard.kde.org/r/129898/diff/
> 
> 
> Testing
> -------
> 
> Checked by building it.
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20170128/0189d999/attachment-0001.html>


More information about the kimageshop mailing list