Junior Job (Bug 245658)

[Sven Langkamp]

On Sun, Mar 9, 2014 at 3:40 PM, Koushik S <skoushik333 at gmail.com> wrote:

> That's a very cool idea, and I've implemented it upto a certain point. It
> currently displays only one color (the FG color), although adding a
> previous color would not be that difficult, I think. Here's the current
> implementation : http://i.imgur.com/nlnIiaT.png
>

The I think that's a bit too color intense. I think maybe it should be just
in one corner like this: http://i.imgur.com/USGDml1.png (color area should
be even smaller). The other corner could be used to a configuration button
(also much smaller).


> Also, you can notice that the color actually takes up the space occupied
> by the brush images. I couldn't figure out how to 'extend' the boundary of
> the popup palette to accommodate it. Can I get some pointers regarding that?
>

You need to increase the size of the widget and then adjust the relative
sizes of everything inside to the new layout.


>
> On Thu, Mar 6, 2014 at 11:08 PM, David Revoy <davidrevoy at gmail.com> wrote:
>
>> >> I want to know how the element should be displayed. I got a suggestion
>> that it must be a square area at one of the corners.
>> Cool ! Here is an open idea proposition to debate about the color
>> position : http://i.imgur.com/BQWrFDM.png
>>
>> _____________________
>> http://www.davidrevoy.com
>>
>>
>> On Thu, Mar 6, 2014 at 6:27 PM, Koushik S <skoushik333 at gmail.com> wrote:
>>
>>> Hi again,
>>>
>>>     So I was messing around with the popup_palette file, and I seem to
>>> have reached upto a point where it can display the foreground color in
>>> whatever path is defined. I want to know how the element should be
>>> displayed. I got a suggestion that it must be a square area at one of the
>>> corners. However, I seem to be having a difficulty in implementing that.
>>> Here's a (failed) attempt to display the selected color in the popup
>>> palette: http://picpaste.com/9sZLF49e.png
>>>
>>>
>>>
>>> On Tue, Feb 25, 2014 at 10:02 AM, Dmitry Kazakov <dimula73 at gmail.com>wrote:
>>>
>>>> Hi, Koushik!
>>>>
>>>> If I understood you right, you already have a KisColorSelectorComponent
>>>> in the pop-up box in the instance of 'm_triangleColorSelector', so yes, you
>>>> can access this method.
>>>>
>>>> Talking about preview of the currently selected color, you might want
>>>> to look at the code in KisColorPreviewPopup class, which is in
>>>> kis_color_selector_base.cpp file. Probably, you would be able to share the
>>>> code between those two classes.
>>>>
>>>>
>>>>
>>>> On Mon, Feb 24, 2014 at 10:07 PM, Koushik S <skoushik333 at gmail.com>wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>>     I was working on and off on Bug 245658 (JJ: Ability to see
>>>>> currently selected color in a pop-up palette), and went through the code in
>>>>> kis_popup_palette (thanks to boud for directing me to it!).
>>>>>
>>>>>     I tried to add code to get the required feature, but to no avail.
>>>>> In fact, the code actually replicated the already built-in feature of
>>>>> displaying the recently used color.
>>>>>
>>>>>     I examined the code which updates the color selector, and have a
>>>>> vague idea of solving this. Would it be correct if I initialize a
>>>>> KisColorSelectorComponent and use it's currentColor() method to get the
>>>>> currently selected color? If not, could someone point me in the right
>>>>> direction. Thanks.
>>>>>
>>>>>
>>>>> --
>>>>> regards,
>>>>> Koushik. S
>>>>>
>>>>> _______________________________________________
>>>>> Krita mailing list
>>>>> kimageshop at kde.org
>>>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dmitry Kazakov
>>>>
>>>> _______________________________________________
>>>> Krita mailing list
>>>> kimageshop at kde.org
>>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>>
>>>>
>>>
>>>
>>> --
>>> regards,
>>> Koushik. S
>>>
>>> _______________________________________________
>>> Krita mailing list
>>> kimageshop at kde.org
>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>
>>>
>>
>> _______________________________________________
>> Krita mailing list
>> kimageshop at kde.org
>> https://mail.kde.org/mailman/listinfo/kimageshop
>>
>>
>
>
> --
> regards,
> Koushik. S
>
> _______________________________________________
> Krita mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20140309/cac27e94/attachment.html>