Vc branch ready for testing

[Dmitry Kazakov]

Hi!

And there is a major bug: the Vc cmake script doesn't add itself into
INCLUDE_DIRECTORIES. This makes compilation fail when Vc is not installed
into system root (which is the common case for developers).

[ 55%] Building CXX object
krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o

/home/devel/kde-src/calligra/krita/image/kis_circle_mask_generator.cpp:25:17:
fatal error: Vc/Vc: No such file or
directory
compilation terminated.
make[2]: ***
[krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o]
Error 1
make[2]: *** Waiting for unfinished jobs....
[ 55%] Built target textshape
make[1]: *** [krita/image/CMakeFiles/kritaimage.dir/all] Error 2
make: *** [all] Error 2



On Thu, Sep 27, 2012 at 7:39 AM, Dmitry Kazakov <dimula73 at gmail.com> wrote:

> Hi!
>
> I've not finished compiling it yet, but at the stage of configuration
> there are two really minor bugs:
>
> 1) When there is no Vc in the system, cmake gives a warning (but succeeds
> with configuration):
>
> CMake Warning at
> /usr/share/kde4/apps/cmake/modules/MacroOptionalFindPackage.cmake:32
> (find_package):
>   Could not find module FindVc.cmake or a configuration file for package
> Vc.
>
>   Adjust CMAKE_MODULE_PATH to find FindVc.cmake or set Vc_DIR to the
>   directory containing a CMake configuration file for Vc.  The file will
> have
>   one of the following names:
>
>     VcConfig.cmake
>     vc-config.cmake
>
>
> Call Stack (most recent call first):
>   krita/CMakeLists.txt:15 (macro_optional_find_package)
>
> 2) In both of the cases, when Vc is present in the system or not, Vc is
> not listed in libraries which are printed by cmake in the end of
> configuration.
>
>
>
> On Thu, Sep 27, 2012 at 7:31 AM, Dmitry Kazakov <dimula73 at gmail.com>wrote:
>
>>
>>
>>>> Yes, I got that too when I tried the same thing. I didn't investigate
>>>> too closely back then, but I can have a look.
>>>
>>>
>>> Problem is solved now. The Vc branch should now be ready for merge.
>>> Anyone want to give it a final round of testing?
>>>
>>
>> I can do it  =)
>>
>> --
>> Dmitry Kazakov
>>
>
>
>
> --
> Dmitry Kazakov
>



-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20120927/76777f84/attachment-0001.html>