[calligra] /: Merge remote branch 'origin/krita-colorsmudge-silvioheinrich'

[Boudewijn Rempt]

On Sunday 20 March 2011 Mar, Silvio Heinrich wrote:
> So my suggestion would be to replace this specific test and test only 
> that the destination pixel has a zero alpha channel, because as i stated 
> before the color is IMHO undefined.

Definitely a good point. But in Krita until now we assumed that full transparency didn't have any meaning for the color channels: the color channels have a value, so they are defined. But in this case I agree that we might need to change the test.

> I tried to make my CompositeOp pass the test, but every time it passes i 
> have the problem again that black color is mixed into the result.

Right, and we don't want that :-).

> So, if you don't like my first suggestion i could restore the old 
> KoCompositeOpCopy2 and create a new CompositeOp. KoCompositeOpCopySmudge 
> or something.
> But i believe that there is an optimization for the COPY CompositeOp 
> that uses memcopy when no blending is needed, right?
> Creating a new Composite op would result in lower performance then...
 
Yes, COPY uses memcpy. We copy everything, transparent or not, without checking.

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org