[calligra] krita/image: Fix crash when updatable rect is empty

[Dmitry Kazakov]

Hi, Boud!

I'm not sure this is a proper place to fix this bug. Because the same bug
may freely appear in e.g. masks and usual filter application. I wonder why
the filter doesn't deal with empty application rect well, this is a common
case for it? I would try to fix the filter first. Did you try it?

Could you explain how this fix fixes the bug?

On Thu, Jun 9, 2011 at 3:19 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> Git commit cbc9d497db3901b24ec75a6c5986dfe63262bc11 by Boudewijn Rempt.
> Committed on 09/06/2011 at 13:17.
> Pushed by rempt into branch 'master'.
>
> Fix crash when updatable rect is empty
>
> Fix  by Cerebrosus. We should't actually do anything if the updaterect
> is empty for some reason.
> BUG:264118
> CCMAIL: BugReporting at cerebrosus.de
>
> M  +4    -0    krita/image/kis_async_merger.h
>
> http://commits.kde.org/calligra/cbc9d497db3901b24ec75a6c5986dfe63262bc11
>
> diff --git a/krita/image/kis_async_merger.h
> b/krita/image/kis_async_merger.h
> index 0702321..d49311e 100644
> --- a/krita/image/kis_async_merger.h
> +++ b/krita/image/kis_async_merger.h
> @@ -97,6 +97,10 @@ public:
>
>         if(!m_projection) return true;
>         QRect applyRect = m_updateRect & m_projection->extent();
> +
> +        // If the intersection of the updaterect and the projection extent
> is
> +        //      null, we are finish here.
> +        if(applyRect.isNull()) return true;
>
>         Q_ASSERT(layer->nodeProgressProxy());
>
>


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110609/8178ca44/attachment.htm