Hi, Boud!<br><br>I'm not sure this is a proper place to fix this bug. Because the same bug may freely appear in e.g. masks and usual filter application. I wonder why the filter doesn't deal with empty application rect well, this is a common case for it? I would try to fix the filter first. Did you try it?<br>
<br>Could you explain how this fix fixes the bug?<br><br><div class="gmail_quote">On Thu, Jun 9, 2011 at 3:19 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Git commit cbc9d497db3901b24ec75a6c5986dfe63262bc11 by Boudewijn Rempt.<br>
Committed on 09/06/2011 at 13:17.<br>
Pushed by rempt into branch 'master'.<br>
<br>
Fix crash when updatable rect is empty<br>
<br>
Fix by Cerebrosus. We should't actually do anything if the updaterect<br>
is empty for some reason.<br>
BUG:264118<br>
CCMAIL: <a href="mailto:BugReporting@cerebrosus.de">BugReporting@cerebrosus.de</a><br>
<br>
M +4 -0 krita/image/kis_async_merger.h<br>
<br>
<a href="http://commits.kde.org/calligra/cbc9d497db3901b24ec75a6c5986dfe63262bc11" target="_blank">http://commits.kde.org/calligra/cbc9d497db3901b24ec75a6c5986dfe63262bc11</a><br>
<br>
diff --git a/krita/image/kis_async_merger.h b/krita/image/kis_async_merger.h<br>
index 0702321..d49311e 100644<br>
--- a/krita/image/kis_async_merger.h<br>
+++ b/krita/image/kis_async_merger.h<br>
@@ -97,6 +97,10 @@ public:<br>
<br>
if(!m_projection) return true;<br>
QRect applyRect = m_updateRect & m_projection->extent();<br>
+<br>
+ // If the intersection of the updaterect and the projection extent is<br>
+ // null, we are finish here.<br>
+ if(applyRect.isNull()) return true;<br>
<br>
Q_ASSERT(layer->nodeProgressProxy());<br>
<br>
</blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>